Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: Modify korean docs headers, title, meta text #23949

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Manual: Modify korean docs headers, title, meta text #23949

merged 2 commits into from
Apr 28, 2022

Conversation

nerdchanii
Copy link
Contributor

Related issue: none

Description

There was an error in the header of the Korean Foundation and it was also in the meta title and nav-list too.
And the <h1>, <title>and <meta name="twitter:title"> tags on each page have no sense of unity. So I made sure that the tag contains Korean and English text.

@Mugen87 Mugen87 changed the title modify korean docs headers, title, meta text Manual: Modify korean docs headers, title, meta text Apr 26, 2022
@Mugen87 Mugen87 added this to the r140 milestone Apr 27, 2022
@mrdoob mrdoob merged commit dfa937b into mrdoob:dev Apr 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 28, 2022

Thanks!

@nerdchanii
Copy link
Contributor Author

nerdchanii commented Apr 28, 2022

@mrdoob Thanks to three.js. This is so fun! Let's meet often! I'll contribute again!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* modify ko/docs title, header, meta title

for a scense of unity

* modify nav-list text for a scense of unity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants