Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Add update() to MarchingCubes #23934

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Apr 22, 2022

Related issue: #22642

Description

Adds support for disabling marching cubes updating every frame automatically in addition to triggering an update on demand since it only needs to rerun when the data changes.

@gkjohnson gkjohnson requested a review from Mugen87 April 22, 2022 17:46
@mrdoob mrdoob added this to the r140 milestone Apr 25, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 25, 2022

Hmm, I think we could just not use onBeforeRender() and force the user to call update() instead? (meaning... no need for autoUpdate)

@gkjohnson
Copy link
Collaborator Author

Hmm, I think we could just not use onBeforeRender() and force the user to call update() instead? (meaning... no need for autoUpdate)

done!

@mrdoob mrdoob changed the title Examples: Add support for disabling auto updating MarchingCubes Examples: Add update() to MarchingCubes Apr 26, 2022
@mrdoob mrdoob merged commit 0e15488 into mrdoob:dev Apr 26, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 26, 2022

Thanks!

@gkjohnson gkjohnson deleted the marching-cubes branch May 18, 2022 23:29
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Add support for disabling auto marching cubes update

* use draw range instead of for loop to limit marching cubes drawing

* remove autoupdate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants