SkinnedMesh: Require floating point vertex textures. #23928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23921.
Description
With
r135the project requires half float texture extension support for HDR workflows in WebGL 1. I'd like to suggest the next step in limiting WebGL 1 support by restricting the usage ofSkinnedMesh.With this PR
SkinnedMeshonly works with WebGL 1 if floating point textures inside the vertex shader are supported. This is true for most WebGL 1 devices however a small subset of older ones do not support this. Stats are rare but according to #20704 and #23921 it is a number around 5 - 10 %.Merging this PR would allow the project to remove a legacy code path which is also buggy. Fixes like suggested in #23922 or #20704 would affect all applications no matter if they use skinning or WebGL 1 or 2.