NodeMaterial: updates and revision #23872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
LeviPesin
reviewed
Apr 9, 2022
|
|
||
| } ); | ||
|
|
||
| const PhysicalLightingModel = new ShaderNode( ( inputs/*, builder*/ ) => { |
There was a problem hiding this comment.
Can it be just const PhysicalLightingModel = RE_Direct_Physical?
There was a problem hiding this comment.
At this moment it make more sense but I will add others functions like RE_IndirectSpecular_Physical soon...
|
Thanks! |
Hmm, do you think we should move |
No, no! I made a mistake in the description only. |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NodeMaterial & WebGPU
physicallyCorrectLightsis default inWebGPURendererBRDFsin individual filesToneMappingNodesupportrenderer.toneMappingNode = new Nodes.ToneMappingNode( ... )FogNode.mix()NodeMaterial.generateOutput()and revision to addIBLsoonWebGPUNodeBuilder.getSamplerBias()VarNode.op( ... )supportReflectedLightNodeShaderNode
ShaderNode( ... )was deprecated, useShaderNode.call( .. )instead of to call a functionaddTo( varNode, ... )was deprecated, usevarNode.add( ... )instead ofcontext,reflectedLightNodePlayground
WebGPUandWebGLexamplesThis contribution is funded by Google via Igalia