Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTextures: Fix DepthTexture's allocation #23868

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

chubei-oppen
Copy link
Contributor

I don't have any test to show this is really a bug. Just found it suspicious during reading code. Feel free to close this PR if I misundertood the code.

This contribution is funded by OppenFuture Technologies.

@Mugen87 Mugen87 added this to the r140 milestone Apr 8, 2022
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 8, 2022

Awesome! Let's merge this for further testing.

@Mugen87 Mugen87 merged commit 3b08a8f into mrdoob:dev Apr 8, 2022
@chubei-oppen chubei-oppen deleted the origin-depth branch April 8, 2022 08:54
@mrdoob
Copy link
Owner

mrdoob commented Apr 8, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* WebGLTextures: Fix DepthTexture's allocation

* WebGLTextures: Rearrange if clauses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants