GLTFLoader: add KHR_materials_emissive_strength #23867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Excellent, thanks!
Most loaders don't have unit tests, other than the tests against the base class, THREE.Loader. For a sufficiently complex feature I think we'd try to work it into an example where appropriate, though we don't really do examples just as tests.
If we wanted a test on this extension I'd suggest modifying the GLB from our bloom example to use KHR_materials_emissive_strength, but that's certainly not required for this PR to be merged.
Co-authored-by: Don McCurdy <[email protected]>
donmccurdy
approved these changes
Apr 8, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* GLTFLoader: add KHR_materials_emissive_strength * only set emissiveIntensity if emissiveStrength is defined Co-authored-by: Don McCurdy <[email protected]> Co-authored-by: Don McCurdy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Took a first stab at implementing KHR_materials_emissive_strength.
cc @donmccurdy
Got a question as well: for this and other new material features, is there a best practice for testing it in three.js? I'm just testing in my viewer PR, but not sure how that is in general handled.
This contribution is funded by 🌵 Needle.