Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTextures: Fix FramebufferTexture's allocation. #23854

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

chubei-oppen
Copy link
Contributor

There were two bugs in the allocation code:

  1. Didn't check if memory needs to be allocated and always used null pixels.
  2. Didn't allocate the memory needed for mipmap.

@Mugen87 for review?

This contribution is funded by OppenFuture Technologies.

There were two bugs in the allocation code:

1. Didn't check if memory needs to be allocated and always used null pixels.
2. Didn't allocate the memory needed for mipmap.
@mrdoob mrdoob added this to the r140 milestone Apr 6, 2022
@mrdoob mrdoob merged commit 80fd48c into mrdoob:dev Apr 6, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 6, 2022

Thanks!

@chubei-oppen chubei-oppen deleted the origin-fbtex branch April 7, 2022 01:55
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
There were two bugs in the allocation code:

1. Didn't check if memory needs to be allocated and always used null pixels.
2. Didn't allocate the memory needed for mipmap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants