Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBXLoader: Fix uv translation being ignored. #23834

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

hybridherbst
Copy link
Contributor

@hybridherbst hybridherbst commented Apr 2, 2022

Description

Seems FBXLoader was applying texture scaling, but not translation.

Reference:
(note that the mirrored 4-cat image uses "Mirror" wrap mode which is not supported in FBX, so no way that can come over unfortunately)
20220402-192850_Unity

Before this PR in three.js:
image

After this PR in three.js:
20220402-200325_chrome

(checking this was super easy thanks to #23773, would be great to have such a simple drag-and-drop viewer for everyone at some point...)

@WestLangley WestLangley added this to the r140 milestone Apr 2, 2022
@Mugen87 Mugen87 changed the title [FBXLoader] Fix UV Translation being ignored FBXLoader: Fix uv translation being ignored. Apr 3, 2022
@mrdoob mrdoob merged commit dded976 into mrdoob:dev Apr 4, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 4, 2022

Thanks!

@hybridherbst hybridherbst deleted the fix-uv-translation-in-fbx-loader branch April 4, 2022 18:10
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants