Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve MeshPhysicalMaterial page. #23831

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Docs: Improve MeshPhysicalMaterial page. #23831

merged 2 commits into from
Apr 4, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 2, 2022

Fixed #23509.

Description

Added some missing properties of MeshPhysicalMaterial. Adapted the descriptions of the KHR_materials_volume spec.

The thickness description is preliminary and has to be enhanced when #23448 is implemented.

@WestLangley
Copy link
Collaborator

I'd suggest using the complete definitions in https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_volume.

(Except the double-sided comment for now.)

@WestLangley
Copy link
Collaborator

The three.js docs specify default values, but fail to specify ranges. This should be fixed throughout the docs.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 2, 2022

I'd suggest using the complete definitions in https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_volume. (Except the double-sided comment for now.)

Done!

The three.js docs specify default values, but fail to specify ranges. This should be fixed throughout the docs.

Agreed. But I'd like to suggest to make this clean up in a different PR and keep the current policy for this one.

@WestLangley
Copy link
Collaborator

I'd like to suggest to make this clean up in a different PR

Oh yes, that is what I assumed. :-)

@WestLangley WestLangley added this to the r140 milestone Apr 2, 2022
@mrdoob mrdoob merged commit 97f9899 into mrdoob:dev Apr 4, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 4, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Docs: Improve MeshPhysicalMaterial page.

* Docs: Clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Some APIs are Undocumented
4 participants