Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometryUtils: Rename and improve warnings for MikkTSpace tangents #23815

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

donmccurdy
Copy link
Collaborator

  • Renamed computeTangents → computeMikkTSpaceTangents
  • Add warnings when position, normal, or uv attributes omitted

Related issue:

- Renamed computeTangents → computeMikkTSpaceTangents
- Add warnings when position, normal, or uv attributes omitted
DeepScan is pretty nice. 🙏
@donmccurdy donmccurdy added this to the r140 milestone Mar 31, 2022
@mrdoob mrdoob merged commit bd3fc5c into mrdoob:dev Mar 31, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2022

Thanks!

@donmccurdy donmccurdy deleted the feat/rename-mikktspace-tangents branch March 31, 2022 19:47
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
…nts (mrdoob#23815)

* BufferGeometryUtils: Rename and improve warnings for MikkTSpace tangents

- Renamed computeTangents → computeMikkTSpaceTangents
- Add warnings when position, normal, or uv attributes omitted

* Add missing computeTangents export

DeepScan is pretty nice. 🙏
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants