Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLUtils: Add WebGL constant fallback to convert(). #23813

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 30, 2022

Related issue: #23228 (comment)

Description

If WebGLUtils.convert() is unable to resolve the given constant, it applies the same logic like for Texture.internalFormat.

@mrdoob mrdoob added this to the r140 milestone Mar 31, 2022
@mrdoob mrdoob merged commit fce7ca7 into mrdoob:dev Mar 31, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2022

Thanks!

@Mugen87 Mugen87 modified the milestones: r140, r139 Apr 1, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants