Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTextures: Ensure texStorage2D() is called when forceUpload is true. #23808

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 29, 2022

Related issue: https://stackoverflow.com/q/71649039/5250847

Description

WebGLTextures has to ensure that texStorage2D() is always called when a new instance of WebGLTexture has been created. The flag to detect this situation already exists, it is just not evaluated at a specific spot.

@Mugen87 Mugen87 added this to the r140 milestone Mar 30, 2022
@Mugen87 Mugen87 merged commit 64d9bf1 into mrdoob:dev Mar 30, 2022
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 30, 2022

Merging for further testing.

@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants