Fix: addEventListener in navigator.xr seems to throw in some cases #23805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we do user agent check instead? Makes the code more readable/maintainable. |
hybridherbst
force-pushed
the
catch-exception-in-sessiongranted
branch
from
c2a3d1b to
4746d6f
Compare
hybridherbst
force-pushed
the
catch-exception-in-sessiongranted
branch
from
4746d6f to
4b66b04
Compare
|
@mrdoob I agree and did now change it to a UA check. Thanks for the feedback! |
Mugen87
approved these changes
Mar 31, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered a weird page crash in Mozilla's WebXR viewer and XR Browser (fork of the former).
Turns out that while those have "navigator.xr", they throw a funny exception when someone actually uses it:
...
So this PR simply catches that exception. Can't hurt I think...
Relevant user agents:
Firefox iOS (does not currently have navigator.xr)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15XRViewer (silent exception when accessing addEventListener)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile WebXRViewer/v2.0(280)XR Browser (silent exception when accessing addEventListener)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.3 WebXRViewer/1.0 Safari/605.1.15