MeshDepthMaterial: Fix broken depthPacking. #23801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Mar 28, 2022
| @@ -259,7 +259,8 @@ function WebGLPrograms( renderer, cubemaps, cubeuvmaps, extensions, capabilities | |||
| doubleSided: material.side === DoubleSide, | |||
| flipSided: material.side === BackSide, | |||
|
|
|||
| depthPacking: ( material.depthPacking !== undefined ) ? material.depthPacking : false, | |||
| useDepthPacking: !! material.depthPacking, | |||
| depthPacking: material.depthPacking || 0, | |||
There was a problem hiding this comment.
I thought using two variables makes the code more clear. useDepthPacking defines whether depth packing should be used or not. depthPacking defines the type of depth packing.
|
Updated builds: a458bc3 |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* MeshDepthMaterial: Fix broken depthPacking. * Clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23784 (comment)
Description
MeshDepthMaterial.depthPackingis not processed byWebGLProgramandWebGLProgramscorrectly.