Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math: Make Euler, Quaternion and Color iterable. #23796

Merged
merged 3 commits into from
Apr 2, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 26, 2022

Fixed #23793.

Description

This PR makes Euler, Quaternion and Color iterable similar to Vector2, Vector3 and Vector4.

@WestLangley
Copy link
Collaborator

Euler is not well-defined without a specified order. Was omitting it intentional?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 26, 2022

Euler is not well-defined without a specified order. Was omitting it intentional?

I don't think most users are interested in the order property. However, I see now that methods like toArray() also honor it. I'll update the PR.

@mrdoob mrdoob added this to the r140 milestone Apr 2, 2022
@mrdoob mrdoob merged commit b857c9d into mrdoob:dev Apr 2, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 2, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Math: Make Euler, Quaternion and Color iterable.

* Euler: Honor order in iterator.

* Update Euler.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Making Euler, Color, Quaternions iterable - and consequently spreadable - like Vector*
4 participants