Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Installation.html #23788

Merged
merged 5 commits into from
Mar 26, 2022
Merged

Update Installation.html #23788

merged 5 commits into from
Mar 26, 2022

Conversation

HossamAbdelNasser
Copy link
Contributor

Related issue: #XXXX

Description

There is no need for "--save", as the packages will be added automatically to the dependencies since npm v5 five years ago, just for the sake of updating.

 There is no need for "--save", as the package will be added automatically to the dependencies since npm v5 five years ago, just for the sake of updating.
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 25, 2022

Good catch! Do you mind updating the translated version of the guide, too?

@HossamAbdelNasser
Copy link
Contributor Author

Good catch! Do you mind updating the translated version of the guide, too?

Sure, no problem

@gsimone
Copy link
Contributor

gsimone commented Mar 25, 2022

@HossamAbdelNasser you can either close the other PRs if they are no longer relevant after this one - and it looks like this one includes all the necessary changes :)

@HossamAbdelNasser
Copy link
Contributor Author

@HossamAbdelNasser you can either close the other PRs if they are no longer relevant after this one - and it looks like this one includes all the necessary changes :)

I've closed the other PRs, thanks :)

@gsimone
Copy link
Contributor

gsimone commented Mar 25, 2022

Awesome! 🤝

@mrdoob mrdoob added this to the r140 milestone Mar 26, 2022
@mrdoob mrdoob merged commit 7a34111 into mrdoob:dev Mar 26, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 26, 2022

Thanks!

@HossamAbdelNasser
Copy link
Contributor Author

Thanks!

You're welcome, my pleasure

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Update Installation.html

 There is no need for "--save", as the package will be added automatically to the dependencies since npm v5 five years ago, just for the sake of updating.

* Update Installation.html

* Update Installation.html

* Update Installation.html

* Update Installation.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants