Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoTexture: Fix color space when using with Scene.background. #23782

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 24, 2022

Fixed #23780.

Description

Video textures are still decoded inline (see #23109 (comment)) so the background shader also needs the code mentioned in #23780.

@nyan-left Do you mind checking if this PR fixes your issue? At least the demo from the codesandbox now renders as expected on my local computer.

@Mugen87 Mugen87 added this to the r139 milestone Mar 24, 2022
@nyan-left
Copy link

That was fast! Thanks @Mugen87.

Taking a look now :)

@nyan-left
Copy link

Yup, does look solved to me. Thanks again!

@mrdoob mrdoob merged commit 1b78202 into mrdoob:dev Mar 24, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 24, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

135+ washed out sRGB VideoTexture when used as scene's background
3 participants