Remove call to checkFramebufferStatus #23770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a perf hit and AFAIK there's not much reason to do the check except to give the user an error message that the browser itself would print. No other place in the code calls checkFramebufferStatus so not sure why this is special. If the framebuffer is not complete you'd be getting rendering warnings from the browser as well.
|
Is it worth guarding this behind a debug flag like we do shader error reporting? https://threejs.org/docs/?q=renderer#api/en/renderers/WebGLRenderer.debug |
|
I'd say no unless you're going to check all WebGL errors throughout the code. I'm not sure what makes this one special. |
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
This is a perf hit and AFAIK there's not much reason to do the check except to give the user an error message that the browser itself would print. No other place in the code calls checkFramebufferStatus so not sure why this is special. If the framebuffer is not complete you'd be getting rendering warnings from the browser as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a perf hit and AFAIK there's not much reason to do the check
except to give the user an error message that the browser itself
would print.
No other place in the code calls checkFramebufferStatus so not sure
why this is special. If the framebuffer is not complete you'd be
getting rendering warnings from the browser as well.
Related issue: #XXXX
Description
A clear and concise description of what the problem was and how this pull request solves it.
This contribution is funded by Example.