Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fromBufferAttribute #23769

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Use fromBufferAttribute #23769

merged 1 commit into from
Mar 23, 2022

Conversation

LeviPesin
Copy link
Contributor

Fixes #23761.

Description

This PR changes quite common uses of vector.x = attribute.getX( i ); vector.y = attribute.getY( i ); to vector.fromBufferAttribute( i ).

@donmccurdy
Copy link
Collaborator

donmccurdy commented Mar 22, 2022 •
edited
Loading

Added documentation:

@mrdoob mrdoob added this to the r139 milestone Mar 23, 2022
@mrdoob mrdoob merged commit 793f66f into mrdoob:dev Mar 23, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 23, 2022

Thanks!

@LeviPesin LeviPesin deleted the use-frombufferattribute branch March 23, 2022 05:57
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@LeviPesin @abernier
Use fromBufferAttribute (mrdoob#23769)
3a0b922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r139
Development

Successfully merging this pull request may close these issues.

proposal: BufferAttribute.copyVector( )
3 participants
@LeviPesin @donmccurdy @mrdoob