NodeMaterial: CubeTexture WebGPU and WebGL #23743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Mar 18, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* fix camera ref * add viewMatrix, cameraPosition and cleanup * fi texture parameter * add getCubeTexture() and bias API update * WebGLNodeBuilder: update bias API * fix refresh uniforms of shared materials * add WebGPUNodeSampledCubeTexture * WebGPURenderer: CubeTexture support * TextureNode: update bias API * add CubeTextureNode and ReflectNode * update examples * Revert "WebGPURenderer: CubeTexture support" This reverts commit 6c62b26. * Revert "Revert "WebGPURenderer: CubeTexture support"" This reverts commit 4498f37. * fix default value of baseArrayLayer * CubeTextureNode instanceof of TextureNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added support for
CubeTextureNodeinWebGPUandWebGL.WebGPU Cube Texture Mipmaps Generating Approach
Initially I copy the image to the texture on the face
z=0, mipLevel=0of the cube like aTexture 2D, then I generate all the mipmaps starting from this face for the other faces in a decreasing way5 .. 0and0 .. mipLevelCountuntil fill the 5 faces. On the last face of the cube I start themipLevelOffsetat 1:1 .. mipLevelCountbecause 0 would already be the correct face of the cube and no longer a temporary one. See here.Live examples
WebGPU
https://raw.githack.com/sunag/three.js/dev-cubemap/examples/webgpu_instance_uniform.html
WebGL
https://raw.githack.com/sunag/three.js/dev-cubemap/examples/webgl_materials_instance_uniform_nodes.html
Updates
CubeTextureNodeandReflectNodeShaderNodeadd viewMatrix, cameraPosition and cleanupNodeBuilderadd getCubeTexture() and bias API updateFixes
WebGLNodesfix refresh uniforms of shared materialsCameraNodefix camera referenceThis contribution is funded by Google via Igalia.