WebGLRenderer: Use texelFetch() to sample morph target texture. #23727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was the issue emerging from that it was written |
|
No, I don't think so. |
|
Thanks! |
|
TIL about |
|
Yes, I think it wasn't available on WebGL1 maybe? But yeah, it's very handy if you don't want interpolation and 0-1 coordinates are not convenient. |
3 tasks
|
After this change, I believe crashes on specific Android devices have been fixed. Crashes have happened in r138, on devices that have PowerVR GE8320 GPU, and happened when loading geometries with a certain amount of vertices and morphs. |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…ob#23727) * WebGLRenderer: Use texelFetch() to sample morph target texture. * Simplify shader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23711
Description
@kenrussell recommended the usage of
texelFetch()to sample the morph target texture (see https://bugs.chromium.org/p/chromium/issues/detail?id=1305968#c4). This actually solves the issue reported in #23711 on a Windows laptop 🎉 .Looking at the details of
texelFetch(), it's indeed the more appropriate function for this use case.