Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTKLoader: fix bit shift when parsing large buffers #23720

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

eino
Copy link
Contributor

@eino eino commented Mar 14, 2022

Description

Fix wrong bitwise shift when parsing VTP headers,
should always be multiple of 8 bits regardless of
header block size.
Fixes parsing of large data buffers.

Fixed #23719

Fix wrong bitwise shift when parsing VTP headers,
should always be multiple of 8 bits regardless of
header block size.
Fixes parsing of large data buffers.
@mrdoob mrdoob added this to the r139 milestone Mar 14, 2022
@mrdoob mrdoob merged commit bb4b303 into mrdoob:dev Mar 14, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 14, 2022

Thanks!

@eino eino deleted the fix/vtp-parsing-block-size branch March 15, 2022 15:08
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Fix wrong bitwise shift when parsing VTP headers,
should always be multiple of 8 bits regardless of
header block size.
Fixes parsing of large data buffers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VTKLoader: decompression error when parsing VTP files of large size
3 participants