VTKLoader: fix parsing VTP containing DataArrays of type Int32 #23699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Mar 10, 2022
Fix parsing of VTP files who contain DataArray nodes of type "Int32". Those nodes were currently ignored.
eino
force-pushed
the
fix/vtp-parsing-int32
branch
from
97d8f38 to
7a6b52c
Compare
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…b#23699) Fix parsing of VTP files who contain DataArray nodes of type "Int32". Those nodes were currently ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix parsing of VTP files who contain DataArray nodes
of type "Int32". Those nodes were currently ignored,
resulting in an exception.
Fixed #23698