Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMREMGenerator: Fix dispose(). #23697

Merged
merged 1 commit into from
Mar 10, 2022
Merged

PMREMGenerator: Fix dispose(). #23697

merged 1 commit into from
Mar 10, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 10, 2022

Fixed #23695.

Description

It's necessary to check if _blurMaterial is null before calling dispose().

@Mugen87 Mugen87 added this to the r139 milestone Mar 10, 2022
@mrdoob mrdoob merged commit 92cbfd2 into mrdoob:dev Mar 10, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 10, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@Mugen87 @abernier
PMREMGenerator: Fix dispose(). (mrdoob#23697)
93fd630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r139
Development

Successfully merging this pull request may close these issues.

In release 138 PMREMGenerator.destroy() reports a TypeError if it was never used
2 participants
@Mugen87 @mrdoob