Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeshStandardMaterial: Remove CubeUVRefractionMapping and refractionRatio. #23682

Merged
merged 2 commits into from
Mar 9, 2022
Merged

MeshStandardMaterial: Remove CubeUVRefractionMapping and refractionRatio. #23682

merged 2 commits into from
Mar 9, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 9, 2022 •
edited
Loading

Fixed #23668.

Description

Removes CubeUVRefractionMapping and the related MeshStandardMaterial.refractionRatio property.

@Mugen87 Mugen87 changed the title MeshStandardMaterial: Remove CubeUVReflectionMapping and refractionRatio MeshStandardMaterial: Remove CubeUVRefractionMapping and refractionRatio. Mar 9, 2022
@mrdoob mrdoob added this to the r139 milestone Mar 9, 2022
@mrdoob mrdoob merged commit d5b82d2 into mrdoob:dev Mar 9, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 9, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Mar 20, 2022
Closed
10 tasks
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@Mugen87 @abernier
MeshStandardMaterial: Remove CubeUVRefractionMapping and refractionRa…
cc54757 
…tio. (mrdoob#23682)

* MeshStandardMaterial: Remove CubeUVRefractionMapping and refractionRatio.

* WebGLPrograms: Clean up.
RenaudRohlinger pushed a commit to pmndrs/three-stdlib that referenced this pull request Sep 26, 2022
@CodyJasonBennett
feat(GLTFLoader): emissive strength, iridescence, morph colors (#190)
3191f75 
* fix(GLTFLoader): update upstream

* chore: add back refractionRatio

Changes from mrdoob/three.js#23682 break semver
Mercury21th000 pushed a commit to Mercury21th000/three-stdlib that referenced this pull request Nov 17, 2024
@CodyJasonBennett
feat(GLTFLoader): emissive strength, iridescence, morph colors (#190)
dee880f 
* fix(GLTFLoader): update upstream

* chore: add back refractionRatio

Changes from mrdoob/three.js#23682 break semver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r139
Development

Successfully merging this pull request may close these issues.

envMaps = refraction not working in r131 for PBR materials
2 participants
@Mugen87 @mrdoob