MathUtils: Make UUID RFC compliant. #23679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@takahirox I remember you looked into the memory implications of this. |
Perhaps, yes. But it was long ago when I looked into it. There is a chance that browsers optimize concatenated strings heap memory space now. I think we need to test again to decide whether we should use |
|
Should we just use |
|
Yeah, using it for now sounds good to me. We can test and remove it if needed later. |
|
Thanks! |
|
I have just checked and Chrome 99 still has the excess memory use problem if the to(Upper/Lower)Case is removed. |
|
@aardgoose thank you! 🙏 |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* MathUtils: Make UUID RFC compliant. * Update MathUtils.js Co-authored-by: mrdoob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #23677.
Description
Makes the UUID RFC compliant by not using uppercase letters.