Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BloomPass: Use custom combine shader. #23667

Merged
merged 2 commits into from
Mar 7, 2022
Merged

BloomPass: Use custom combine shader. #23667

merged 2 commits into from
Mar 7, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 7, 2022 •
edited
Loading

Related issue: -

Description

BloomPass uses CopyShader for its implementation. In this context, it maps its strength property to opacity which is not correct since strength isn't restricted to the [0-1] range. BloomPass actually misuses CopyShader in an unexpected way.

I think it's less confusing when BloomPass has its own combine shader.

@mrdoob mrdoob added this to the r139 milestone Mar 7, 2022
@mrdoob mrdoob merged commit 1ba0eb4 into mrdoob:dev Mar 7, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 7, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
@Mugen87 @donmccurdy
BloomPass: Use custom combine shader. (mrdoob#23667)
ecbf709 
* BloomPass: Use custom combine shader.

* Examples: Clean up.
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@Mugen87 @abernier
BloomPass: Use custom combine shader. (mrdoob#23667)
99edac7 
* BloomPass: Use custom combine shader.

* Examples: Clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r139
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob