HtmlMesh doesn't handle html comment #23657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTMLMesh was not working when the html has a comment (see err below). And use Node constants https://developer.mozilla.org/fr/docs/Web/API/Node/nodeType. Add basic example of html with list in webxr_vr_sandbox ``` HTMLMesh.js:258 Uncaught TypeError: Cannot read properties of undefined (reading 'display') at drawElement (HTMLMesh.js:258) at drawElement (HTMLMesh.js:307) at html2canvas (HTMLMesh.js:337) at new HTMLTexture (HTMLMesh.js:54) at new HTMLMesh (HTMLMesh.js:14) at init (webxr_vr_sandbox.html:224) at webxr_vr_sandbox.html:62 ```
No need! |
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
* HTMLMesh fix html comment, constants and basic html example HTMLMesh was not working when the html has a comment (see err below). And use Node constants https://developer.mozilla.org/fr/docs/Web/API/Node/nodeType. Add basic example of html with list in webxr_vr_sandbox ``` HTMLMesh.js:258 Uncaught TypeError: Cannot read properties of undefined (reading 'display') at drawElement (HTMLMesh.js:258) at drawElement (HTMLMesh.js:307) at html2canvas (HTMLMesh.js:337) at new HTMLTexture (HTMLMesh.js:54) at new HTMLMesh (HTMLMesh.js:14) at init (webxr_vr_sandbox.html:224) at webxr_vr_sandbox.html:62 ``` * Update webxr_vr_sandbox.html * Update webxr_vr_sandbox.html Co-authored-by: mrdoob <[email protected]>
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* HTMLMesh fix html comment, constants and basic html example HTMLMesh was not working when the html has a comment (see err below). And use Node constants https://developer.mozilla.org/fr/docs/Web/API/Node/nodeType. Add basic example of html with list in webxr_vr_sandbox ``` HTMLMesh.js:258 Uncaught TypeError: Cannot read properties of undefined (reading 'display') at drawElement (HTMLMesh.js:258) at drawElement (HTMLMesh.js:307) at html2canvas (HTMLMesh.js:337) at new HTMLTexture (HTMLMesh.js:54) at new HTMLMesh (HTMLMesh.js:14) at init (webxr_vr_sandbox.html:224) at webxr_vr_sandbox.html:62 ``` * Update webxr_vr_sandbox.html * Update webxr_vr_sandbox.html Co-authored-by: mrdoob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HTMLMesh didn't handled when html contains comment
<!-- this is a comment! -->. Fix that. (Should I had first created an issue?)Also use Node constants instead of magic number.
Add an example in webxr_vr_sandbox
That error was output when the html had a comment :
Try it here (I'll probably update the example on my gh-page next days, as I would like to add more feature which faile : shadowRoot, event / changes not reflected, etc...)