WebGPURenderStates: Basic implementation #23652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Mar 4, 2022
|
Would Node.uuid be still needed if Node.id will be added? |
|
@LeviPesin Node.uuid is used in .toJSON() mainly. |
|
@sunag Is this ready to go? |
|
@mrdoob yes, yes! |
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
* add Node.id property * Move static .fromLights() to property and update .getHash() * WebGPURenderStates: minimal implementation
sunag
added a commit
to sunag/three.js
that referenced
this pull request
Mar 11, 2022
mrdoob
pushed a commit
that referenced
this pull request
Mar 11, 2022
* add MatcapUVNode * FileURLEditor + MatcapUVEditor * WebGPUNodeBuilder: fix scene lights after #23652 * fix unserialize * cleanup * cleanup(2) * normalize x
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* add Node.id property * Move static .fromLights() to property and update .getHash() * WebGPURenderStates: minimal implementation
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* add MatcapUVNode * FileURLEditor + MatcapUVEditor * WebGPUNodeBuilder: fix scene lights after mrdoob#23652 * fix unserialize * cleanup * cleanup(2) * normalize x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's use scene lights automatically in a
LightsNode.This contribution is funded by Google via Igalia.