Add ivec, uvec, bvec, imat, umat, and bmat #23646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
reviewed
Mar 3, 2022
I'am just not a bit sure about put a input like |
|
Thanks!! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
* Add ivec, uvec, bvec, imat, umat, and bmat * Fix * Change the way how it is done * Fix * Another fix * Fix bvec
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Add ivec, uvec, bvec, imat, umat, and bmat * Fix * Change the way how it is done * Fix * Another fix * Fix bvec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23564
Description
This PR adds ivec, uvec, bvec, imat, umat, and bmat types.
Possibly WebGPUNodeBuilder._getNodeUniform() method should also be updated, but I am unsure how.