Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NodeBuilder.format() #23638

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Refactor NodeBuilder.format() #23638

merged 3 commits into from
Mar 3, 2022

Conversation

LeviPesin
Copy link
Contributor

Related issue: -

Description

Completely refactored NodeBuilder.format().

@sunag
Copy link
Collaborator

sunag commented Mar 3, 2022

@LeviPesin It seems that because of PR ( #23636 ) introduced some conflicts.

@sunag sunag modified the milestone: r139 Mar 3, 2022
@LeviPesin
Copy link
Contributor Author

@sunag I have resolved them.

Copy link
Collaborator

@sunag sunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!!

@sunag sunag merged commit 4710868 into mrdoob:dev Mar 3, 2022
@LeviPesin LeviPesin deleted the patch-3 branch March 3, 2022 14:05
@sunag sunag mentioned this pull request Mar 3, 2022
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* Refactor NodeBuilder.format()

* Fix for toType === null
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Refactor NodeBuilder.format()

* Fix for toType === null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants