-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Texture: Set needsUpdate to true in copy(). #23637
Conversation
I think the best solution for this is to do |
I did not suggested to do that in #22718 because it does not solve the following issue: const loader = new THREE.TextureLoader();
const texture = loader.load( 'path/to/my/texture.png' );
const clonedTexture = texture.clone(); // needsUpdate set to true too early However, modifying
I'll update the PR. |
|
Ah the problem is that cloned textures for render targets now have a version greater |
@Mugen87 if we have two textures with the same Source, what does |
No, this does not happen with The are a couple of design issues in |
Thanks! |
* Texture: Set needsUpdate to true in copy(). * Fix WebGLMultipleRenderTargets.
Cherry-picked into the |
* Texture: Set needsUpdate to true in copy(). * Fix WebGLMultipleRenderTargets.
Fixed #23627.
Description
Texture.clone()
requires a manual definition ofTexture.needsUpdate
(see #22718).