Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFLoader: Clean up #23633

Merged
merged 1 commit into from
Mar 3, 2022
Merged

GLTFLoader: Clean up #23633

merged 1 commit into from
Mar 3, 2022

Conversation

donmccurdy
Copy link
Collaborator

No description provided.

takahirox
takahirox approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have overlooked that we use arrow functions in GLTFLoader.

@mrdoob mrdoob added this to the r139 milestone Mar 3, 2022
@mrdoob mrdoob merged commit 5957f0b into mrdoob:dev Mar 3, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 3, 2022

Thanks!

@donmccurdy donmccurdy deleted the feat-gltfloader-cleanup-texture-clone branch March 3, 2022 20:43
donmccurdy added a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
@donmccurdy
GLTFLoader: Clean up (mrdoob#23633)
4546792
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@donmccurdy @abernier
GLTFLoader: Clean up (mrdoob#23633)
f265cb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirox takahirox takahirox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r139
Development

Successfully merging this pull request may close these issues.
3 participants
@donmccurdy @mrdoob @takahirox