GLTFExporter: Only merge roughness and metalness maps #23616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry-picked into |
mrdoob
commented
Mar 1, 2022
Comment on lines
+750
to
+751
| // TODO Use new Source() instead? | ||
| texture.source = new Texture( canvas ).source; |
There was a problem hiding this comment.
I was looking for a nice way of copying all the properties of a texture and change the source but I ended up doing this hack because seems like we're currently not exposing THREE.Source.
What do you think?
There was a problem hiding this comment.
Initially, THREE.Source was meant to be an internal thing.
However, looking at your code it would be indeed nicer to expose THREE.Source and use it in the mentioned line.
Merged
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23229 (comment)