Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Src: Set WebGLRenderTarget texture.flipY to false #23607

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

WestLangley
Copy link
Collaborator

PMREM CubeUV textures have .flipY set to true. But .flipY does not apply to render target textures.

I think the most appropriate fix is for WebGLRenderTarget to set .flipY to false.

/ping @Mugen87

@WestLangley
Copy link
Collaborator Author

Continuing to set .flipY to false in other derived classes is OK, but one could argue it would be less confusing to set .flipY only when necessary. I do not have a strong opinion either way.

@WestLangley WestLangley added this to the r139 milestone Feb 27, 2022
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 28, 2022

So this change is only for clarity, right? Although flipY is not apply to render target textures, it less confusing to set its default to false.

@WestLangley
Copy link
Collaborator Author

Yes. I exported a PMREM texture and imported it, and the .flipY flag changed from true to false. I then discovered it was the WebGLRenderTarget class that failed to set the flag.

@mrdoob mrdoob merged commit 1574137 into mrdoob:dev Feb 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 28, 2022

Thanks!

@WestLangley WestLangley deleted the dev-flipY branch February 28, 2022 20:35
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants