Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewHelper: Fixed container is not defined. #23605

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

linbingquan
Copy link
Contributor

Related issue: #--

Description

As the title.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 28, 2022

/cc @sunag (9a6f817)

@WestLangley WestLangley added this to the r139 milestone Feb 28, 2022
@Mugen87 Mugen87 merged commit a079d4b into mrdoob:dev Feb 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 28, 2022

Thanks!

@linbingquan
Copy link
Contributor Author

@mrdoob I saw you released bugfix version, but https://threejs.org/editor/ also has an error.
image

@linbingquan linbingquan deleted the dev-viewhelper branch March 1, 2022 05:40
@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2022

@linbingquan Oh, I'll cherry-pick this PR into gh-pages too.

mrdoob pushed a commit that referenced this pull request Mar 1, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2022

Done! 364cf4e

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants