Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataUtils: Added fromHalfFloat(), rewrite toHalfFloat(). #23596

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 26, 2022

Fixed #23563.

Description

This PR adds DataUtils.fromHalfFloat() and rewrites DataUtils.toHalfFloat(). Both helpers are now based on the following reference: http://www.fox-toolkit.org/ftp/fasthalffloatconversion.pdf

@WestLangley WestLangley added this to the r139 milestone Feb 27, 2022
@mrdoob mrdoob merged commit 947f01e into mrdoob:dev Feb 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 28, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Mar 1, 2022
10 tasks
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* DataUtils: Added fromHalfFloat(), rewrite toHalfFloat().

* Tests: Fix half float conversion tests.
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* DataUtils: Added fromHalfFloat(), rewrite toHalfFloat().

* Tests: Fix half float conversion tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add .fromHalfFloat() to DataUtils.
3 participants