Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Mentioned Import Maps in Installation guide. #23595

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 26, 2022

Related issue: #23427 (comment)

Description

Updates the Installation guide to honor the introduction of Import Maps in three.js.

@LeviPesin
Copy link
Contributor

Maybe the section "Import maps" in the "Compatibility" should be removed now?

@marcofugaro
Copy link
Contributor

Thank you, I am in favor of removing all occurrences of skypack 👍

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 26, 2022

Both feedbacks should be implemented 👍 .

@LeviPesin
Copy link
Contributor

The second paragraph of "Import maps" also should be removed, I think :-)

@Mugen87 Mugen87 added this to the r139 milestone Feb 27, 2022
@Mugen87 Mugen87 merged commit 1b2882a into mrdoob:dev Feb 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 28, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* Docs: Mentioned Import Maps in Installation guide.

* Docs: Clean up.

* Docs: More clean up.
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Docs: Mentioned Import Maps in Installation guide.

* Docs: Clean up.

* Docs: More clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants