Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS2DRenderer: Fix culling regression. #23594

Merged
merged 1 commit into from
Feb 26, 2022
Merged

CSS2DRenderer: Fix culling regression. #23594

merged 1 commit into from
Feb 26, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 26, 2022

Fixed #23593.

Description

Fixed a culling regression in CSS2DRenderer. The _vector variable always needs an update so its z value can be used for testing.

Also cleaned up some code style issues in CSS3DRenderer.

@Mugen87 Mugen87 added this to the r139 milestone Feb 26, 2022
@Mugen87 Mugen87 merged commit 30f34a3 into mrdoob:dev Feb 26, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 28, 2022

Thanks!

mrdoob pushed a commit that referenced this pull request Feb 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 28, 2022

Cherry-picked into master and published 0.138.1.

@Mugen87 Mugen87 modified the milestones: r139, r138 Feb 28, 2022
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All CSS2DObjects disappear if one of them gets outside view frustum
2 participants