Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZExporter: Support opacity materials #23588

Merged

Conversation

yuta-hayashi
Copy link
Contributor

Fixed #22205
Related issue: google/model-viewer#2476

Description

Added support for displaying materials with transparent textures.

I implemented this by referring to the USD spec and RealityConverter's output.

Tested with Reality Converter on mac os and iOS 15.3.1 AR QuickLook, works!

The photos below were taken of this model using the AR QuickLook on the iPhone.

Before After
image image

@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2022

That output is not correct, but it's pretty close.
I'll merge and experiment locally.

@mrdoob mrdoob added this to the r139 milestone Feb 25, 2022
@mrdoob mrdoob merged commit 5d81b27 into mrdoob:dev Feb 25, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2022

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2022

Actually, seems like the code is correct and their viewers are not behaving as the USD spec says:

Screen Shot 2022-02-25 at 12 57 09 PM

@hybridherbst I found this related issue. Is this supposed to work now?

@hybridherbst
Copy link
Contributor

hybridherbst commented Feb 25, 2022

I haven't tested usdview for quite a while (and not since they closed this issue). It had a lot of subtle bugs in rendering and there's no real reference viewer for USD, which makes deciding what's right harder than it should be...

My comment in that issue

they [QuickLook] seem closer to the spec but also not right

refers to exactly this incorrect behaviour of masking still becoming transparent, so the (wrong as per the spec) output in the photo above would be expected from a correct USDZ in the slightly incorrect QuickLook USD implementation. Never got a response to any of my bug reports to Apple unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usdz exporter transparency not applied on iOS
3 participants