Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix transparency in material browser. #23576

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Docs: Fix transparency in material browser. #23576

merged 3 commits into from
Feb 24, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 24, 2022

Related issue: https://discourse.threejs.org/t/opacity-bug-in-materials-documentation/35251

Description

Since Material.transparent controls the opaque program parameter, it is necessary to call needsUpdate to true if the transparency setting changes over time.

@bergden-resonai
Copy link
Contributor

I think this doc should be updated as well:
https://threejs.org/docs/?q=update#manual/en/introduction/How-to-update-things

I find it very hard to know what does or doesn't require needsUpdate and it's very hard to understand from reading the codebase
I'm guessing doing setters for these attributes is a bad idea because it will causes unwarranted compiles, but maybe the docs can include a mention of this in the relevant page (as well as the general "How to update things" page)?

@mrdoob mrdoob added this to the r139 milestone Feb 24, 2022
@mrdoob mrdoob merged commit ba4b34c into mrdoob:dev Feb 24, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 24, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* Docs: Fix transparency in material browser.

* Docs: Update guide.

* Docs: Clean up.
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Docs: Fix transparency in material browser.

* Docs: Update guide.

* Docs: Clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants