Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Move new NodeMaterial system to ./jsm/nodes/ #23560

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 23, 2022

Description

  • Imports nodes from three-nodes/
  • Move jsm/renderers/nodes/ to jsm/nodes/

This contribution is funded by Google via Igalia.

@sunag sunag requested a review from mrdoob February 23, 2022 00:25
@mrdoob mrdoob added this to the r138 milestone Feb 23, 2022
@mrdoob mrdoob merged commit 82c8132 into mrdoob:dev Feb 23, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 23, 2022

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Feb 23, 2022

FYI 1244316

@donmccurdy
Copy link
Collaborator

donmccurdy commented Feb 23, 2022

Related to #23406 and #23368 (comment) — is three-nodes an alias or a new NPM package? If we don't intend to publish it to NPM then I wonder if we should use a name that bundlers can resolve, like three/nodes or @three/nodes.

@donmccurdy
Copy link
Collaborator

Filed a new issue in #23625.

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants