Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more functions to the ShaderNode #23539

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Add more functions to the ShaderNode #23539

merged 5 commits into from
Feb 21, 2022

Conversation

LeviPesin
Copy link
Contributor

Related issue: -

Description

Added the int function and few operators to the ShaderNode.

@sunag
Copy link
Collaborator

sunag commented Feb 20, 2022

Very nice! I think that is necessary normalize these new operators here too:

} else if ( op === '==' || op === '&&' ) {

@LeviPesin
Copy link
Contributor Author

Done, thanks!

@sunag sunag added this to the r138 milestone Feb 20, 2022
@sunag sunag merged commit 31df72c into mrdoob:dev Feb 21, 2022
@sunag
Copy link
Collaborator

sunag commented Feb 21, 2022

Thanks!

@LeviPesin LeviPesin deleted the patch-3 branch February 21, 2022 07:30
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* Update ShaderNode.js

* Add remainder operator

* Add xor

* Update OperatorNode.getNodeType

* Fix % operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants