SVGLoader: recognize style definitions inside defs tag #23533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! The current implementation of SVGLoader never traverses nodes inside
<defs>
tag. But besides geometry, it may contain CSS style definitions that should be accessible to paths outside the<defs>
.Here's an SVG (included in the PR):
This is a simplified example of typical Adobe Illustrator and CorelDRAW output: they put styles in
<defs>
. This SVG is correctly rendered in yellow + red with Firefox and Chrome, but incorrectly with three.js:This patch does the fix: