Replace deprecated String.prototype.substr()

[CommanderRoot]

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

[Mugen87]

It seems the webgl_loader_svg is breaking with this change.

[CommanderRoot]

This had me puzzled for longer than I want to admit. I fixed it now and the CI tests are passing.

[mrdoob]

Why slice() instead of substring()?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring

[CommanderRoot]

Both have their use cases. Both return the same in most cases but can differ if the second parameter is smaller than the first or negative.
I personally like that slice() has less "magic" and is more likely to act the way you want to (or think it does). For example in cases where you expect the second parameter to be possibly negative and you want to replicate substr() you would use substring() other than that I like to use slice()

[mrdoob]

Seems like substring() is more strict?

[CommanderRoot]

I would say the opposite due to the parameter switching substring() can do but I guess it really depends on how you plan to provide the input variables to these functions.

[mrdoob]

For example in cases where you expect the second parameter to be possibly negative and you want to replicate substr() you would use substring()

Hmm.... Is that why you're using substring() in ColladaLoader.js and webgl_geometry_text.html?

[CommanderRoot]

That's correct. In both cases the first parameter is >= 0. If the second one would be negative substring() will return an empty string (like substr()), slice() however would return everything from the start until the last x chars

[mrdoob]

Thanks!