-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PointerLockControls: Add .pointerSpeed
.
#23516
Conversation
`mouseSpeed` controls the mouse sensitivity for `PointerLockControls`. This change also adds a new optional `options` parameter to the constructor of `PointerLockControls`.
We do not have that option in the the other controls, so I'd omit it.
As implemented in this PR, the units of // Or, maybe better, implement it like so: _euler.y -= movementX * 0.002 * mouseSpeed; In that case, I'd defer to @mrdoob for the choice of parameterization. |
Agreed.
Agreed too. |
I think I can make these changes directly here... 🤔 |
One more issue... Should it be |
Maybe |
I vote for |
These are all great ideas! I've added two more commits. The first renames The second commit adds documentation for the Please let me know if there's anything else you would like me to change, or feel free to make your own changes. |
Thanks! |
mouseSpeed
property to PointerLockControls
.pointerSpeed
.
.pointerSpeed
..pointerSpeed
.
* Add `mouseSpeed` property to `PointerLockControls` `mouseSpeed` controls the mouse sensitivity for `PointerLockControls`. This change also adds a new optional `options` parameter to the constructor of `PointerLockControls`. * Update PointerLockControls.js * Update PointerLockControls.js * Rename `mouseSpeed` to `pointerSpeed` * Add `pointerSpeed` property documentation Co-authored-by: mrdoob <[email protected]>
Related issue: #23513
Description
This PR adds a new
mouseSpeed
property toPointerLockControls
. Changing this property changes the mouse sensitivity for controlling the camera look direction. The PR also adds a new optionaloptions
parameter to the constructor for settingmouseSpeed
when a newPointerLockControls
instance is made.