GLTFExporter: Fix buildORMTexture() #23463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently buildORMTexture() returns Texture.image if aoMap.image, roughnessMap.image, and metalnessMap.image are identical but it should return Texture. This PR fixes the problem by returning Texture.
|
Oh, that's actually a bug yeah. |
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
Currently buildORMTexture() returns Texture.image if aoMap.image, roughnessMap.image, and metalnessMap.image are identical but it should return Texture. This PR fixes the problem by returning Texture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
buildORMTexture()inGLTFExporterreturnsTexture.imageifaoMap.image,roughnessMap.image, andmetalnessMap.imageare identical but it should returnTexturefor the type consistency and the return value is used forprocessTexture(), passingTexture.imageto it can cause an error.This PR fixes the problem by returning
Texture.This is just an easy and quick fix. We may need some more tweaks and clean up.