Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign 3MF object names to the created groups and meshes. #23453

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

kovacsv
Copy link
Contributor

@kovacsv kovacsv commented Feb 10, 2022

Description

3MF contains names for the objects in it. For some viewers it's useful to have these names in the loaded three.js objects as well. A 3MF object becomes a THREE.Group, and now it gets the name of the object. I also assign the name of the object to all the THREE.Mesh objects inside the group to make sure that every object has a proper name.

@mrdoob mrdoob added this to the r138 milestone Feb 10, 2022
@mrdoob mrdoob merged commit 900fa37 into mrdoob:dev Feb 10, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 10, 2022

Thanks!

@kovacsv kovacsv deleted the 3mf_object_names branch February 10, 2022 16:21
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants