Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLCubeRenderTarget: Simplify constructor. #23443

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 8, 2022

Related issue: -

Description

It's been two years since the constructor of WebGLCubeRenderTarget accepts size instead of width and height.

I think it's okay to remove the fallback now which allows to simplify the ctor and align it to the other render targets.

@mrdoob mrdoob added this to the r138 milestone Feb 8, 2022
@mrdoob mrdoob merged commit ce51b61 into mrdoob:dev Feb 8, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 8, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Mar 1, 2022
16 tasks
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants