Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material: Clean up. #23438

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Material: Clean up. #23438

merged 1 commit into from
Feb 6, 2022

Conversation

linbingquan
Copy link
Contributor

Related issue: #---

Description

Keep the same name. isRoot -> isRootObject.

three.js/src/core/Object3D.js

Line 632 in e619fe5

const isRootObject = ( meta === undefined || typeof meta === 'string' );

three.js/src/textures/Texture.js

Line 145 in e619fe5

const isRootObject = ( meta === undefined || typeof meta === 'string' );

three.js/src/textures/Source.js

Line 24 in e619fe5

const isRootObject = ( meta === undefined || typeof meta === 'string' );

@mrdoob mrdoob added this to the r138 milestone Feb 6, 2022
@mrdoob mrdoob merged commit 9dceefe into mrdoob:dev Feb 6, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 6, 2022

Thanks!

@linbingquan linbingquan deleted the dev-material branch February 7, 2022 10:36
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
@linbingquan @donmccurdy
Material: Clean up. (mrdoob#23438)
ad67346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r138
Development

Successfully merging this pull request may close these issues.
2 participants
@linbingquan @mrdoob